Figure and Editable Caption

#1

This question has been asked a few times before but I haven’t seen a definitive answer.

What’s the best way to do an editable caption inside an element (like an image or figure) in terms of the schema and dom structure?

1 Like
#2

I experimented with that kind of thing and here is how far I got:

if you define the figure in the schema as block, all goes (mostly) as expected, at the dom structure just put image and figcaption inside a figure dom element and you will be able to edit the caption. What did not work out of the box for me, was the ability to select the figure node, when clicking anywhere inside the figure, but outside the figcaption (so I did some ugly hack processing the raw event to work around).

if you define the figure as inline, then all kind of unexpected things will happen, @marijn mentioned some months ago that he hasn’t yet finalized / smoothed out the code related to inline non-leaf nodes

#3

Thanks, that helps a lot! Do you think you could post how that related part of your schema looks like?

#4

Sure, here are the relevant parts:

figure: {
    content: "text<_>*",
    group: "block",
    attrs: {
      // ....
      // non-relevant
      // ....
    },
    draggable: true,
    selectable: true,
    parseDOM: [{tag: "figure", getAttrs(dom) {
      // ....
      // non-relevant
      // ....
    }}],
    toDOM(node) {
      // ....
      // create myImageAsReactContainer and others
      // ....
      return ['figure', {
        class: myClass,
        style: myStyle,
        // more attributes
      }, myImageAsReactContainer, ['figcaption', {}, 0]]
    }
  },

What issues did you run into ?

#5

Here’s another, possibly more complete example doing something similar.

const imageNodeDesc = {
  figure: {
    attrs: {src: {}},
    content: "inline<_>*",
    parseDOM: [{
      tag: "figure",
      contentElement: "figcaption", // Helps the parser figure out where the child nodes are
      getAttrs(dom) {
        let img = dom.querySelector("img")
        return {src: img && img.parentNode == dom ? img.src : "default_image.jpg"}
      }
    }],
    toDOM(node) {
      return ["figure", ["img", {src: node.attrs.src}], ["figcaption", 0]]
    },
    draggable: true,
    group: "block",
  }
}

To cause the node to be selected on click, even though it isn’t a leaf node, you could use the handleClickOn prop, passing something like…

function handleFigureClick(view, pos, node, posBefore) {
  if (node.type.name != "figure" && pos != posBefore) return false
  view.props.onAction(new NodeSelection(view.state.doc.resolve(pos).action())
  return true
}
#6

what does this content expression mean?

#7

Nothing, in current versions of the library. It used to be possible to specify allowed marks per child node, which is what the angle brackets did, but that never worked right and marks are now specified per parent node.

#8

Tried it, but there is some unexpected behaviour. It’s possible to put cursor right after the image and type something. And there is no way to delete it afterwards.

Screenshot_20190804_225924
Screenshot_20190804_225924.png530×549 114 KB

1 Like
#9

I did this with figcaption decoration that is being inserted once image is selected. Decoration element has also mousedown listener which inserts a figcaption node at that position:

wrap_cap = new Slice(Fragment.from(oView.state.schema.nodes.figcaption.create()),0,0)
wrap_pos = figure_node_position + figure_node_size  - 1;
oTrans.replace(wrap_pos, wrap_pos, wrap_cap);

based on my schema:

figure: {
	content: "(embed | image*) figcaption{0,1}",
	group: "block",
	marks: "",
	parseDOM: [{tag: "figure"}],
	toDOM() {                         
		return ["figure", 0] 
	}
},
figcaption: {
	content: "inline*",
	group: "figure",
	marks: "strong link",
	parseDOM: [{tag: "figcaption"}],
	toDOM(node) { 
	  return ["figcaption", 0] 
	}
}

figcaption
figcaption.gif1576×936 137 KB

2 Likes
#10

@pet Im struggling to implement this as I still fail to grasp Prosemirror…Would you please share your implementation in a glitch possibly?

#11

@ahwei This is not exactly how I have this feature implemented right now but logic is kind of the same.

I didn’t bother with details so you might need to review and test…

2 Likes
Deleting a Nested Node
#12

@pet Thank you sooo much for getting back! :bowing_man:

#13

Is there a way to remove the duplicate image in that example when html with a figure element with figurecaption and image are pasted? I’m wondering if this has to do with the figure have two children nodes, so it’s parsed twice. I tried comparing this to marijn’s example, as it doesn’t have the duplicate image, but has that cursor issue instead.

Edit 1: Added print statements to the toDom function. It looks like image is parsed 3 times, figurecaption is parsed 2 times, and figure is parsed once.

Edit 2: It looks like adding a contentElement: "figcaption" to the figure schema helps with this issue. :slight_smile: