Wired failure on step.apply(doc) on same set of steps

[mortyccp]

Merging steps in collab

I wrote a mergeStepsArray that receives an array of steps and returns an array of steps with as much merging as possible: function mergeStepsArray(steps) { let res = [], current = steps[0]; for (let i = 1; i < steps.length; i++) { let newStep=current.merge(steps[i]); if (newStep) { current = newStep; } else { res.push(current); current = steps[i]; } } res.push(current) return res; } (as a side note, writing this was trick…

I found out the reason. Seem there is a mergeSteps function being run when saving to the mongo. And the merged steps are invalid when replay. After removing that, the problem is solved.

btw, if we really want to merge the steps before saving into mongo in order to reduce the number of step. Any suggestion on how to do that?

input
{
    "payload": [
        {
            "stepType": "replace",
            "from": 69,
            "to": 70
        },
        {
            "stepType": "replace",
            "from": 69,
            "to": 70
        },
        {
            "stepType": "replace",
            "from": 68,
            "to": 71,
            "slice": {
                "content": [
                    {
                        "type": "text",
                        "text": " "
                    }
                ]
            }
        },
        {
            "stepType": "replace",
            "from": 69,
            "to": 71,
            "structure": true
        },
        {
            "stepType": "replace",
            "from": 69,
            "to": 71,
            "structure": true
        }
    ]
}

merged
{
    "payload": [
        {
            "stepType": "replace",
            "from": 69,
            "to": 71
        },
        {
            "stepType": "replace",
            "from": 68,
            "to": 71,
            "slice": {
                "content": [
                    {
                        "type": "text",
                        "text": " "
                    }
                ]
            }
        },
        {
            "stepType": "replace",
            "from": 69,
            "to": 73,
            "structure": true
        }
    ]
}

Is that because of the structure?