Is `nodeType` right ？

1

File : prosemirror-view/domchange.js at master · ProseMirror/prosemirror-view · GitHub

code Fragment

  if (browser.chrome && view.lastKeyCode === 8) {
    for (let off = toOffset; off > fromOffset; off--) {
      let node = parent.childNodes[off - 1], desc = node.pmViewDesc
      if (node.nodeType == "BR" && !desc) { toOffset = off; break }
      if (!desc || desc.size) break
    }
  }
2

You’re saying it should be

-     if (node.nodeType == "BR" && !desc) { toOffset = off; break }
+     if (node.nodeName == "BR" && !desc) { toOffset = off; break }

right? Edit: looked into this-ish fix check if node is BR by BrianHung · Pull Request #90 · ProseMirror/prosemirror-view · GitHub

1 Like
3

yes. You fixed it fast.

4

Fixed in this patch.