ProseMirror + Remirror dispatch setNodeAttribute not working as expected

brockklein · November 22, 2024, 8:15am

Hey all! I’m new to ProseMirror (via Remirror) and am having an issue with my first use of a dispatch + Transaction.

I know this is a discussion board for ProseMirror not Remirror, but I’m hoping maybe my issue is on the ProseMirror side and/or there may be some folks here familiar with Remirror (their Discord is rather dead and I’ve not had luck getting insights there).

I’ve created a simple custom extension for Remirror that implements a ProseMirror Node (from what I can tell). It’s very simple - it stores an id in the attributes and I want to be able to update that ID based on a user action outside the editor.

As far as I can tell I have followed all the steps for successfully setting up and dispatching a transaction, but the change is never rendered in the editor.

I have a repro repo here: GitHub - brockklein/remirror-test: Repro steps Remirror/Prosemirror questions

Any help/insight would be greatly appreciated!

s524797336 · November 23, 2024, 9:36am

github.com

brockklein/remirror-test/blob/97350a23c97090aa97cd8cc442b51c687d493077/src/App.tsx#L28


      
          			fieldId: 'initial-id',
          		})
          
          		if (!templateFieldNode) throw new Error('Cannot find node in the document')
          
          		const { pos } = templateFieldNode
          
          		const customDispatch = remirrorRef.current.commands.customDispatch
          
          		customDispatch(({ tr, dispatch }) => {
          			tr.setNodeAttribute(pos, 'id', 'new-id')
          
          			if (dispatch) {
          				console.log('dispatched the transaction', tr)
          				dispatch(tr)
          			}
          
          			return true
          		})
          
          		setContentId('new-id')

Change this line to

tr = tr.setNodeAttribute(pos, 'id', 'new-id')

brockklein · November 23, 2024, 1:23pm

Thank you for taking a look! Sadly no go…I made that change and the dispatch still doesn’t appear to work. You can see even without that change the Transaction appears to have the right steps in it:

s524797336 · November 23, 2024, 3:22pm

github.com/brockklein/remirror-test

🐞 fix(findNode): unexpected usage for node.descendants

brockklein:main ← s524797336:main

opened 03:21PM - 23 Nov 24 UTC

s524797336

+14 -15

`node.descendants` will iterate through all the child nodes of the given `node`,… with `pos` starting from 0. Since you called it recursively, each new parent will also start from 0. Additionally, this method continues traversing to the end of the current parent even when `return false` is triggered. Therefore, it's more efficient to write a custom `for` loop instead.

brockklein · December 2, 2024, 12:02pm

@s524797336 just wanted to follow up here and let you know, per my response on your Github PR, this solved the problem! Clearly a misunderstanding on my part on how node.descendants operates. Thank you again, very much, for your help here!