Prosemirror-search, problem with setSearchState

1

Hi,

Got into a problem with this code:

replace: (replaceTerm) => ({ state, dispatch, view }) => {
	const searchState = getSearchState(state);
	
	if (!searchState) return false;
	const query = new SearchQuery({
		search: searchState.query.search,
		replace: replaceTerm,
		caseSensitive: searchState.query.caseSensitive,
		regexp: searchState.query.regexp,
		wholeWord: searchState.query.wholeWord,
	});
	if (dispatch) {
		setSearchState(state.tr, query);
		const result = replaceNext(state, dispatch);
		return result;
	}
	return replaceNext(state);
},

The problem is that the state doesn’t change immediately. I believe it requires at least a dispatch() of some sort, but adding dispatch(state.tr); right before replaceNext() will not help either – the state stays unchanged.

So I’m at loss how to get the state changed before replaceNext() and do the replace with the correct replace term.

2

Someone (Claude & Grok) also suggested this, but this won’t replace text at all:

replace: (replaceTerm) => ({ state, dispatch, view }) => {
	const searchState = getSearchState(state);

	if (!searchState) return false;

	// Create a new SearchQuery with the replace term
	const query = new SearchQuery({
		search: searchState.query.search,
		replace: replaceTerm,
		caseSensitive: searchState.query.caseSensitive,
		regexp: searchState.query.regexp,
		wholeWord: searchState.query.wholeWord,
	});

	if (dispatch) {
		// Create a transaction and set the new search state
		const tr = state.tr;
		setSearchState(tr, query);

		// Dispatch the transaction to update the state
		dispatch(tr);

		// Apply the transaction to get the updated state
		const newState = state.apply(tr);

		// Now call replaceNext with the updated state
		return replaceNext(newState, dispatch);
	}

	// If no dispatch, just return the result of replaceNext with original state
	return replaceNext(state);
},

The original code is also from Grok.

3

This won’t do anything. It’ll return a transaction which you then ignore, causing it to take no effect. You’ll want to dispatch its return value.

4

This also won’t have the correct replace term in replaceNext(). In replaceNext(), the query that it gets is the previous one (the one that exists before setSearchState is called):

	const transaction = setSearchState(state.tr, query);
	dispatch(transaction);
	replaceNext(state, dispatch);

So, this also didn’t help. I obviously don’t know how to use this, it could take a day to figure it out.

Asking for more help…

5

I found the reason why dispatch doesn’t work:

image

But I don’t know yet why it’s like that.

It seems that dispatch comes from @tiptap/core so maybe this is a Tiptap-related issue.

6

It seems that Tiptap likes to call dispatch on its own, and I should not intervene. So I solved this by splitting the setSearchState and replaceNext in separate commands:

	this.editor.commands.setReplaceTerm(value);
	this.editor.commands.replace();
7

So my earlier problem was solved.

I just use this thread to ask about another problem:

It seems to me that findNext and findPrev return true?

I think the intention was to return SearchResult (GitHub - ProseMirror/prosemirror-search: Search/replace functionality for ProseMirror)?

findNext(state: EditorState, from?: number = 0, to?: number = state.doc.content.size) → SearchResult