Resolved: Prosemirror-dropcursor with `disableDropCursor` option is not published

colel · November 11, 2021, 2:38pm

Just a heads up, it appears that the latest code of prosemirror-dropcursor which is supposed to use disableDropCursor from nodespec, is not released.

For example: https://unpkg.com/browse/prosemirror-dropcursor@1.3.5/dist/index.es.js

Versus:

github.com

ProseMirror/prosemirror-dropcursor/blob/28ae5a63b769f39aa1c3de55845d5a4efc060212/src/dropcursor.js#L9-L23

    
      
          // Nodes may add a `disableDropCursor` property to their spec to
          // control the showing of a drop cursor inside them. This may be a
          // boolean or a function, which will be called with a view and a
          // position, and should return a boolean.
          //
          //   options::- These options are supported:
          //
          //     color:: ?string
          //     The color of the cursor. Defaults to `black`.
          //
          //     width:: ?number
          //     The precise width of the cursor in pixels. Defaults to 1.
          //
          //     class:: ?string
          //     A CSS class name to add to the cursor element.

Cheers!

colel · November 11, 2021, 2:48pm

I started pulling this into my project, and started converting to TypeScript, and it does appear this code is not actually working yet. ~I found the following type errors:~

github.com

ProseMirror/prosemirror-dropcursor/blob/28ae5a63b769f39aa1c3de55845d5a4efc060212/src/dropcursor.js#L93-L96

    
      
          if (!parent || parent == document.body && getComputedStyle(parent).position == "static") {
            parentLeft = -pageXOffset
            parentTop = -pageYOffset
          } else {

~Where pageXOffset & pageYOffset are not defined.~

edit: My bad, these are just window/globalThis properties

marijn · November 11, 2021, 2:58pm

Indeed, that was an oversight. I’ve released 1.4.0

colel · November 11, 2021, 3:00pm

Thanks!