Toggle editor editable

[var]

Hi, I am having some problems about toggle editor editable to no-editable or no-editable to editable,

1. when I toggle editor editable to no-editable, it also can insert one char.
2. when I toggle editor no-editable to editable, it can not select words during first focus time.

Hulking Materialistic Crow

1. When I disable the editor, I can still enter the character “b”。

   

2. When I enable the editor, I can not select any character.

   

Thanks! Any help greatly appreciated!

[marijn]

view.editable seems to always be true in that demo, so there’s probably some other issues in this code.

[var]

I’m so sorry! The demo above has been edited. There is a minimal reproducible demo here .

Glitch

Thanks!

[marijn]

editable: () => { return window.editable; }

The editor will only call editable when it updates. So you can change window.editable all you want, it just won’t notice. A better approach would be to define a plugin with a state field that tracks whether the editor is editable, have the editable prop return the value of that field, and use transactions (with an annotation) to update the state field (properly, via its apply reducer, not by mutating something).

[lucywang000]

@marijn

The editor will only call editable when it updates. So you can change window.editable all you want, it just won’t notice.

But according to the source code, View.setProps would call View.updateStateInner, which would update View.editable state immediately.

I tried it in the browser and the contententeditable attribute is indeed updated immedately.