When comparing nodes using .eq(), what exactly is being compared?

linsannety · January 26, 2022, 11:29pm

Mainly because when I do something like JSON.stringify(node1.toJSON()) === JSON.stringify(node2.toJSON()), because the contents are the same, this will return true, but for some reason node1.eq(node2), it’s false. I just want a better understanding of what makes nodes different besides its contents.

Thanks!

bhl · January 27, 2022, 4:49am

github.com

ProseMirror/prosemirror-model/blob/95298fb02744e1a8f41eae50f8a6afde583a8817/src/node.js#L115-L119

    
      
          // :: (Node) → bool
          // Test whether two nodes represent the same piece of document.
          eq(other) {
            return this == other || (this.sameMarkup(other) && this.content.eq(other.content))
          }

Content and markup (type, attributes, and marks).

marijn · January 27, 2022, 10:20am

That’s is stringifying the toJSON methods, not the JSON structure they return, which might be what’s causing this.

linsannety · January 27, 2022, 7:15pm

oh actually I mistyped, I meant

JSON.stringify(node1.toJSON()) === JSON.stringify(node2.toJSON())

marijn · January 28, 2022, 6:52am

That shouldn’t happen — do you have a code example that reproduces it?